From 20985f8985d810092a84f31a705144b9318235dd Mon Sep 17 00:00:00 2001 From: Ben Sima Date: Tue, 14 May 2024 11:18:58 -0400 Subject: Test that llama-cpp is buildable This small Llamacpp.py file is simply intended to test that llama.cpp can build. This was previously not working, I guess, because the build system doesn't verify that the final executable has its dependencies set properly in $PATH. Not sure if it *should* do that verification or not. Anyway, I rewrote this to actually test if it could call `llama`, and it could not, because the Python builder needed the rundeps in its propagatedBuildInputs. That alone makes `llama` available to the final artifact, but the test still failed. This is because the wrapPythonPrograms function from nixpkgs (which adds stuff to PATH) is called in postFixup, which happens after installPhase, but checkPhase happens before installPhase. So I was testing a program that didn't have PATH set yet. Moving the test to installCheck fixed this because it runs after the postFixup phase. I opted to keep the lint/typecheck stuff in the checkPhase because they don't need any external dependencies, and having those fail earlier is probably better? Maybe doesn't make a huge difference time-wise but it kinda makes the intention clearer to be separate, in checkPhase you are checking the code itself, in installCheck you are including the installation environment as well. --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) (limited to 'pyproject.toml') diff --git a/pyproject.toml b/pyproject.toml index e8266ae..62eebf4 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -27,6 +27,7 @@ ignore = [ "E203", # whitespace-before-punctuation, doesn't work with ruff format "INP001", # implicit-namespace-package "N999", # invalid-module-name + "PT009", # pytest-unittest-assertion, conflicts with assert (S101) "S310", # suspicious-url-open-usage, doesn't work in 0.1.5 "S404", # suspicious-subprocess-import, not stable "S603", # subprocess-without-shell-equals-true, false positives -- cgit v1.2.3