summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Sima <ben@bsima.me>2022-08-08 09:56:53 -0400
committerBen Sima <ben@bsima.me>2022-08-08 09:56:53 -0400
commite9d639f7d6f21498c450db36d46e1e6ac6c0b17e (patch)
tree05d826528fe7c4f964f4f97dbf794e22da162883
parentaf3707e3acd8dc169506109410674f9f054eb1a7 (diff)
Remove some TODOs
I don't like TODOs in my codebase, I'd rather keep them in org files. Eventually I need a linter that prevents all TODOs from getting into code.
-rw-r--r--Biz/Bild.hs2
-rw-r--r--Biz/Bild/Deps.hs1
-rw-r--r--Biz/Cloud/Git.nix1
-rw-r--r--Biz/Dev/Configuration.nix2
-rw-r--r--Biz/Dev/Wireguard.nix2
-rwxr-xr-xBiz/Ide/push2
-rw-r--r--Urbit/Harbor.hs5
-rw-r--r--Urbit/Harbor.nix7
-rw-r--r--bs/logic.scm2
-rw-r--r--bs/repl.scm2
-rw-r--r--bs/string.scm2
-rw-r--r--bs/test.scm6
12 files changed, 9 insertions, 25 deletions
diff --git a/Biz/Bild.hs b/Biz/Bild.hs
index 68aa971..75d012f 100644
--- a/Biz/Bild.hs
+++ b/Biz/Bild.hs
@@ -639,7 +639,7 @@ build andTest loud analysis = do
toLog (Local u) = u
toLog (Remote u h) = u <> "@" <> h
Copy -> do
- Log.warn ["bild", "copy", "TODO", nschunk namespace]
+ Log.warn ["bild", "copy", "not implemented yet", nschunk namespace]
pure Exit.ExitSuccess
Rustc -> do
Log.info ["bild", "dev", "rust", nschunk namespace]
diff --git a/Biz/Bild/Deps.hs b/Biz/Bild/Deps.hs
index 89c4516..515d04c 100644
--- a/Biz/Bild/Deps.hs
+++ b/Biz/Bild/Deps.hs
@@ -378,7 +378,6 @@ parseCmdShow =
((cmdShow </ Opts.optional parsePackageName) <**> Opts.helper)
<| Opts.progDesc "Show information about a dependency in human-readable format"
--- TODO: nicer output
cmdShow :: Maybe PackageName -> NIO ()
cmdShow = \case
Just packageName -> do
diff --git a/Biz/Cloud/Git.nix b/Biz/Cloud/Git.nix
index fadf2aa..55ca441 100644
--- a/Biz/Cloud/Git.nix
+++ b/Biz/Cloud/Git.nix
@@ -22,7 +22,6 @@ in {
(lib.strings.splitString "\n")
lib.lists.head
];
- # TODO: this is broken
# commonHooks = [ ./git-hooks ];
};
gitDaemon = {
diff --git a/Biz/Dev/Configuration.nix b/Biz/Dev/Configuration.nix
index 8e316ed..114aee8 100644
--- a/Biz/Dev/Configuration.nix
+++ b/Biz/Dev/Configuration.nix
@@ -204,6 +204,6 @@ in {
# should.
system.stateVersion = "20.09"; # Did you read the comment?
- # TODO: upstream this
+ # TODO: is this still necessary? Check nixpkgs upstream
users.users.jupyter.isSystemUser = true;
}
diff --git a/Biz/Dev/Wireguard.nix b/Biz/Dev/Wireguard.nix
index b4c26a5..90f425e 100644
--- a/Biz/Dev/Wireguard.nix
+++ b/Biz/Dev/Wireguard.nix
@@ -59,7 +59,7 @@ in {
peers = [
#{ # helium
- # publicKey = "TODO";
+ # publicKey = "";
# allowedIPs = [ "10.100.0.2/32" ];
#}
{ # ben's iPhone
diff --git a/Biz/Ide/push b/Biz/Ide/push
index a0109e8..f6b9b98 100755
--- a/Biz/Ide/push
+++ b/Biz/Ide/push
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
-# TODO: convert to haskell, see:
+# Eventually convert to haskell, see:
# - https://github.com/awakesecurity/nix-deploy/blob/master/src/Main.hs
# - http://www.haskellforall.com/2018/08/nixos-in-production.html
prefix=$(echo $PWD | sed -e "s|^$BIZ_ROOT/*||g")
diff --git a/Urbit/Harbor.hs b/Urbit/Harbor.hs
index 8c53e0c..1477c37 100644
--- a/Urbit/Harbor.hs
+++ b/Urbit/Harbor.hs
@@ -31,11 +31,6 @@ Service Template:
[Install]
WantedBy=multi-user.target
-TODO:
- - use systemd.resource-control to limit memory/CPU for ships
- - Urbit.Cloud controller will set different limits by reading/editing the
- ini file, and change price to customer
- - figure out what firewall stuff i need to do
-}
module Urbit.Harbor where
diff --git a/Urbit/Harbor.nix b/Urbit/Harbor.nix
index 72507d0..50abc53 100644
--- a/Urbit/Harbor.nix
+++ b/Urbit/Harbor.nix
@@ -31,13 +31,6 @@ Service Template:
[Install]
WantedBy=multi-user.target
-
-
-TODO:
- - use systemd.resource-control to limit memory/CPU for ships
- - Urbit.Cloud controller will set different limits by reading/editing the
- ini file, and change price to customer
- - figure out what firewall stuff i need to do
*/
let
diff --git a/bs/logic.scm b/bs/logic.scm
index 1e25b1c..c555f03 100644
--- a/bs/logic.scm
+++ b/bs/logic.scm
@@ -1,5 +1,5 @@
;; my mini kanren impl - basically untested so far
-;; TODO: https://github.com/webyrd/faster-miniKanren
+;; See also: https://github.com/webyrd/faster-miniKanren
(define-module (bs logic))
diff --git a/bs/repl.scm b/bs/repl.scm
index 3bf1ca1..65eb50d 100644
--- a/bs/repl.scm
+++ b/bs/repl.scm
@@ -10,8 +10,6 @@
;; (vector-ref (uname) 1)
;; (pwd))))
-;; TODO(bsima): (doc x)
-
(eval-when (compile load eval)
(define-meta-command ((src nala) repl (form))
"Print source code of specified Scheme procedure."
diff --git a/bs/string.scm b/bs/string.scm
index 9fe794e..136572b 100644
--- a/bs/string.scm
+++ b/bs/string.scm
@@ -14,7 +14,7 @@
(only (srfi srfi-14)
string->char-set char-set-complement char-set)
(only (srfi srfi-28) format)
- ;; TODO: remove or port ice-9 dependency
+ ;; TODO: port ice-9 dependency or replace with (scheme something)
(only (ice-9 ports) with-output-to-string))
(define (prefix? s pre)
diff --git a/bs/test.scm b/bs/test.scm
index a45bca1..5d5a2c6 100644
--- a/bs/test.scm
+++ b/bs/test.scm
@@ -6,9 +6,9 @@
#:select (prn))
#:export (testing))
-;; TODO: learn srfi-64
-;; TODO: port over `deftest' et al from clojure
-;; TODO: someday a quickcheck-like would be best
+;; - learn srfi-64
+;; - port over `deftest' et al from clojure
+;; - someday a quickcheck-like would be best
;; simple analog to clojure's `testing'
(define-syntax testing