summaryrefslogtreecommitdiff
path: root/depo/hidor-kahih/hardware.nix
diff options
context:
space:
mode:
authorBen Sima <ben@bsima.me>2024-05-14 11:18:58 -0400
committerBen Sima <ben@bsima.me>2024-05-20 22:15:50 -0400
commit20985f8985d810092a84f31a705144b9318235dd (patch)
treef3a8cb4c71dc77f23598b6e377cb1ed81afefca4 /depo/hidor-kahih/hardware.nix
parent2d33aa547ff6a516c90ca2b47b13e2add200583a (diff)
Test that llama-cpp is buildable
This small Llamacpp.py file is simply intended to test that llama.cpp can build. This was previously not working, I guess, because the build system doesn't verify that the final executable has its dependencies set properly in $PATH. Not sure if it *should* do that verification or not. Anyway, I rewrote this to actually test if it could call `llama`, and it could not, because the Python builder needed the rundeps in its propagatedBuildInputs. That alone makes `llama` available to the final artifact, but the test still failed. This is because the wrapPythonPrograms function from nixpkgs (which adds stuff to PATH) is called in postFixup, which happens after installPhase, but checkPhase happens before installPhase. So I was testing a program that didn't have PATH set yet. Moving the test to installCheck fixed this because it runs after the postFixup phase. I opted to keep the lint/typecheck stuff in the checkPhase because they don't need any external dependencies, and having those fail earlier is probably better? Maybe doesn't make a huge difference time-wise but it kinda makes the intention clearer to be separate, in checkPhase you are checking the code itself, in installCheck you are including the installation environment as well.
Diffstat (limited to 'depo/hidor-kahih/hardware.nix')
0 files changed, 0 insertions, 0 deletions