1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
|
{-# LANGUAGE DeriveAnyClass #-}
{-# LANGUAGE LambdaCase #-}
{-# LANGUAGE OverloadedStrings #-}
{-# LANGUAGE QuasiQuotes #-}
{-# LANGUAGE RecordWildCards #-}
{-# LANGUAGE NoImplicitPrelude #-}
-- | Global linter.
--
-- : out lint
-- : run ormolu
-- : run hlint
-- : run black
-- : run ruff
-- : run deadnix
-- : run shellcheck
-- : run indent
-- : run nixfmt
module Biz.Lint (main) where
import Alpha
import qualified Biz.Cli as Cli
import qualified Biz.Log as Log
import Biz.Namespace (Ext (..), Namespace (..))
import qualified Biz.Namespace as Namespace
import Biz.Test ((@=?))
import qualified Biz.Test as Test
import qualified Data.Aeson as Aeson
import qualified Data.ByteString.Char8 as Char8
import qualified Data.Map as Map
import qualified Data.String as String
import qualified Data.Text as Text
import qualified System.Directory as Directory
import qualified System.Environment as Environment
import qualified System.Exit as Exit
import qualified System.Process as Process
main :: IO ()
main = Cli.main <| Cli.Plan help move test pure
move :: Cli.Arguments -> IO ()
move args =
Environment.getEnv "CODEROOT" +> \root ->
case Cli.getAllArgs args (Cli.argument "file") of
[] ->
changedFiles
+> traverse Directory.makeAbsolute
/> map (Namespace.fromPath root)
/> catMaybes
/> Namespace.groupByExt
+> run mode
+> exit
files ->
files
|> filter (not <. Namespace.isCab)
|> traverse Directory.makeAbsolute
+> filterM Directory.doesFileExist
/> map (Namespace.fromPath root)
/> catMaybes
/> Namespace.groupByExt
+> run mode
+> exit
where
mode = args `Cli.has` Cli.longOption "fix" ?: (Fix, Check)
test :: Test.Tree
test =
Test.group
"Biz.Lint"
[ Test.unit "haskell files return two Results" <| do
results <- run Check <| Map.singleton Hs <| [Namespace ["Biz", "Lint"] Hs]
length results @=? 2
]
help :: Cli.Docopt
help =
[Cli.docopt|
all your lint are belong to us
Usage:
lint test
lint [options] [<file>...]
Options:
--fix, -f Apply fixes automatically
--help, -h Print this info
|]
exit :: [Result] -> IO ()
exit results = Exit.exitWith <| (n > 0) ?: (Exit.ExitFailure n, Exit.ExitSuccess)
where
n = length <| filter bad results
bad = \case
(Warn _) -> False
Done _ (Bad _) -> True
_ -> False
printResult :: Result -> IO Result
printResult r = case r of
Warn err ->
Log.warn ["lint", err]
>> Log.br
>> pure r
Done (Linter {..}) (Bad err) ->
Log.fail ["lint", exe]
>> Log.br
>> (err /= "")
?| (putText <| Text.pack err)
>> pure r
Done (Linter {..}) Good ->
Log.good ["lint", exe]
>> Log.br
>> pure r
NoOp ext ->
Log.info ["lint", "noop", show ext]
>> pure r
changedFiles :: IO [FilePath]
changedFiles =
git ["merge-base", "HEAD", "origin/live"]
/> filter (/= '\n')
+> (\mb -> git ["diff", "--name-only", "--diff-filter=d", mb])
/> String.lines
where
git args = Process.readProcess "git" args ""
data Mode
= -- | Just check the files and return an exit code.
Check
| -- | Fix the files in place, return 0 if successful, otherwise return 1.
Fix
data Linter = Linter
{ exe :: Text,
-- | Arguments added when in the "check" mode
checkArgs :: [Text],
-- | Arguments added when in the "fix" mode
fixArgs :: Maybe [Text],
-- | An optional function to format the output of the linter as you want
-- it, perhaps decoding json or something
formatter :: Maybe (String -> String)
}
ormolu :: Linter
ormolu =
Linter
{ exe = "ormolu",
checkArgs = ["--mode", "check", "--no-cabal"],
fixArgs = Just ["--mode", "inplace", "--no-cabal"],
formatter = Nothing
}
hlint :: Linter
hlint =
Linter
{ exe = "hlint",
checkArgs = [],
-- needs apply-refact >0.9.1.0, which needs ghc >9
-- fixArgs = Just ["--refactor", "--refactor-options=-i"]
fixArgs = Nothing,
formatter = Nothing
}
black :: Linter
black =
Linter
{ exe = "black",
checkArgs = ["--check"],
fixArgs = Just [],
formatter = Nothing
}
ruff :: Linter
ruff =
Linter
{ exe = "ruff",
checkArgs = ["check"],
fixArgs = Just ["check", "--fix"],
formatter = Nothing
}
data DeadnixOutput = DeadnixOutput
{ file :: FilePath,
results :: [DeadnixResult]
}
deriving (Generic, Aeson.FromJSON)
data DeadnixResult = DeadnixResult
{ column :: Int,
endColumn :: Int,
line :: Int,
message :: String
}
deriving (Generic, Aeson.FromJSON)
deadnix :: Linter
deadnix =
Linter
{ exe = "deadnix",
checkArgs = "--fail" : commonArgs,
fixArgs = Just <| "--edit" : commonArgs,
formatter = Just decodeDeadnixOutput
}
where
commonArgs =
[ -- "--no-underscore",
-- "--no-lambda-pattern-names",
"--output-format",
"json"
]
decodeDeadnixOutput :: String -> String
decodeDeadnixOutput deadnixJson =
deadnixJson |> Char8.pack |> Aeson.decodeStrict |> \case
Nothing -> panic "could not decode deadnix output"
Just o -> formatDeadnixOutput o
where
formatDeadnixOutput DeadnixOutput {..} =
joinWith "\n" <| map formatDeadnixResult results
where
formatDeadnixResult DeadnixResult {..} =
file <> ":" <> show line <> ":" <> show column <> ": " <> message
nixfmt :: Linter
nixfmt =
Linter
{ exe = "nixfmt",
checkArgs = ["--check"],
fixArgs = Nothing,
formatter = Nothing
}
shellcheck :: Linter
shellcheck =
Linter
{ exe = "shellcheck",
checkArgs = [],
fixArgs = Nothing,
formatter = Nothing
}
indent :: Linter
indent =
Linter
{ exe = "indent",
checkArgs = [],
fixArgs = Nothing,
formatter = Nothing
}
data Status = Good | Bad String
deriving (Show)
data Result
= Done Linter Status
| Warn Text
| NoOp Namespace.Ext
run :: Mode -> Map Namespace.Ext [Namespace] -> IO [Result]
run mode nsmap = nsmap |> Map.assocs |> traverse (runOne mode) /> concat
runOne :: Mode -> (Ext, [Namespace]) -> IO [Result]
runOne mode (ext, ns's) = results +> traverse printResult
where
results :: IO [Result]
results =
-- i would run these with mapConcurrently, but the output gets mangled. to
-- do it right i need a queue for the results. someday.
sequence <| case ext of
Namespace.Hs ->
[ lint mode ormolu ns's,
lint mode hlint ns's
]
Namespace.Py ->
[ lint mode black ns's,
lint mode ruff ns's
]
Namespace.Sh -> [lint mode shellcheck ns's]
Namespace.Nix -> [lint mode deadnix ns's, lint mode nixfmt ns's]
Namespace.C -> [lint mode indent ns's]
_ ->
ns's
|> map Namespace.toPath
|> joinWith ", "
|> str
|> ("no linter for " <>)
|> Warn
|> (pure :: Result -> IO Result)
|> (pure :: IO Result -> [IO Result])
lint :: Mode -> Linter -> [Namespace] -> IO Result
lint mode linter@Linter {..} ns's =
Log.info ["lint", exe, (tshow <| length ns's) <> " files"]
>> Process.readProcessWithExitCode (str exe) args "" /> \case
(Exit.ExitSuccess, _, _) ->
Done linter Good
(Exit.ExitFailure _, msg, _) -> case formatter of
Nothing -> Done linter <| Bad msg
Just fmt -> Done linter <| Bad <| fmt msg
where
args = case (mode, fixArgs) of
(Fix, Just args_) ->
map str args_ ++ map Namespace.toPath ns's
(Fix, Nothing) ->
map Namespace.toPath ns's
(Check, _) ->
map str checkArgs ++ map Namespace.toPath ns's
|